Favor methods over closure fields #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hopefully, not too many fixes like this should follow, still working on switching docs.rs from |
|
To call a function in the current scope, you have to call |
|
Should be the same as the current situation but having more tests is always a good idea! |
GuillaumeGomez
force-pushed
the
method-call
branch
from
b9009f5
to
4a76c40
Compare
|
Added test and updated docs (which were not mentioning functions surprisingly). |
GuillaumeGomez
force-pushed
the
method-call
branch
from
4a76c40
to
d0bcba7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very surprisingly, we can't call methods directly, however closures (which are fields) can be called. I don't think this incentive makes sense as methods are much more common than closures as fields. Also, it now follows the rust syntax way.